Conversation
We simply needed to upstream `TypeSubstCloner::visitDifferentiableFunctionExtractInst`. The code has a detailed comment explaining what it does.
|
@swift-ci please test |
|
Merging to unblock progress! |
|
Is it possible that this change caused a failure on some linux bots? I saw what (I think) is an unrelated error when testing my PR and tracked the error to this forum post and then here. Error: |
|
Thanks, much appreciated. Let me know if I can help. I can see that it passed before it was committed. But, this commit is also the only one in the blame list so it's likely flaky (or needs a config that's present on only some bots). |
|
My guess right now is that it was a flake caused by the worker being low on memory or disk, not by anything the test does. Evidence for this hypothesis:
So I'd suggest running the tests again, if you don't mind. If this test does fail again, then we can disable it and spend more time investigating why it is flaky. |
|
That sounds good to me. Thanks for doing a full investigation. The reason I thought that it might not be a one-time thing is both the incremental build (see forum post) and my PR had the error. But, it could easily be something else (given the logs from the forum post are unfortunately missing). |
|
We're seeing this test fail erratically on some configurations. (Most recently, Ubuntu 20.04). Any thoughts? |
We simply needed to upstream
TypeSubstCloner::visitDifferentiableFunctionExtractInst.The code has a detailed comment explaining what it does.
Resolves SR-12493.